Add servicing build targeting pack skip config #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
force-pushed
the
servicing-skips
branch
from
9e894e4 to
3965da0
Compare
|
@MichaelSimons @vatsan-madhavan @zsd4yr PTAL and merge if ok. I locked myself out when I renounced my adminity. 🙂 Might be reasonable to give |
MichaelSimons
approved these changes
Nov 12, 2019
|
I'm not an expert in this but lgtm. |
|
If there's someone in particular on the WPF or WinForms teams who handles (will be handling) servicing build version updates, it would be nice to have them take a look at this to make sure the workflow at least makes sense. |
|
/cc @RussKie, @AdamYoblick |
|
FYI @zsd4yr has left the WinForms team, please don't tag him any longer. |
|
Closing, dotnet/runtime#639 tracks a known issue with the current impl and merging a fixed version into both dotnet/runtime and dotnet/windowsdesktop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/dotnet/core-setup/issues/8735. Uses dotnet/arcade#4318.
This sets up the WindowsDesktop targeting pack to only get built in stable builds if there's an intentional patch release. For 3.0/3.1, this is being done in Core-Setup:
3.0: dotnet/core-setup#8827
3.1: dotnet/core-setup#8828